You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The final Sol High + Fable High review for #167 certified the required dual-review path, but both reviewers identified two nonblocking P2 gaps isolated to the standalone fable-review.cjs adapter:
Its live preflight uses a synchronous timeout boundary that does not itself prove the complete child process tree is terminated on timeout or cancellation.
It validates the requested/actual model during preflight, then accepts the certifying review without independently validating model identity from that review runs own init stream.
The dual-review path added by #167 is candidate-bound, supervised, and certified. This issue must not reopen #167 or become a 1.0 blocker without new evidence.
Scope
Put standalone preflight and review execution under the same bounded process-tree supervision contract used by the dual-review path.
On timeout or cancellation, terminate descendants on POSIX and Windows and write a truthful non-certifying receipt.
Validate the actual standalone review model from its own structured init envelope, not solely from a preceding probe.
Evidence
The final Sol High + Fable High review for #167 certified the required dual-review path, but both reviewers identified two nonblocking P2 gaps isolated to the standalone fable-review.cjs adapter:
The dual-review path added by #167 is candidate-bound, supervised, and certified. This issue must not reopen #167 or become a 1.0 blocker without new evidence.
Scope
Acceptance criteria
Related