Show not-installed packages on Modules page with install instructions - #414
Merged
Conversation
ddon
added a commit
that referenced
this pull request
Mar 15, 2026
…le SQS broadcast counter
- Extract duplicated permission check in roles template into @can_manage_permissions assign
- Replace Module.concat("Broadcast") with newsletters_mod.increment_broadcast_counter/2 call
- Remove unused Ecto.Query import from SQS processor
- Add PR review files for #413 and #414
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a section to the admin Modules page that displays known PhoenixKit packages which are not yet installed, along with install instructions.
Changes
ModuleRegistry.not_installed_packages/0— filtersknown_external_packages/0viaCode.ensure_loaded?ModuleRegistry— privateknown_external_packages/0list (currently:phoenix_kit_newsletters)UX
Each card shows:
mix.exsline:{:phoenix_kit_newsletters, "~> 0.1"}The section only appears when there are uninstalled known packages. Once a package is added to deps and the app is restarted, the card disappears and the module appears in the main grid as a regular external module.
Test plan
mix compile --warnings-as-errorspassesmix credo --strict— no issues