Skip to content

Fix test and worker guard after Newsletters extraction #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddon merged 1 commit into from
Mar 16, 2026
Merged

Fix test and worker guard after Newsletters extraction #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/phoenix_kit/scheduled_jobs/workers/process_scheduled_jobs_worker.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@ defmodule PhoenixKit.ScheduledJobs.Workers.ProcessScheduledJobsWorker do

if newsletters_mod && Code.ensure_loaded?(newsletters_mod) &&
function_exported?(newsletters_mod, :enabled?, 0) &&
function_exported?(newsletters_mod, :process_scheduled_broadcasts, 0) &&
newsletters_mod.enabled?() do
{:ok, newsletters_count} = newsletters_mod.process_scheduled_broadcasts()

Expand Down
3 changes: 1 addition & 2 deletions test/phoenix_kit/module_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,6 @@ defmodule PhoenixKit.ModuleTest do
PhoenixKit.Modules.Storage,
PhoenixKit.Modules.Sync,
PhoenixKit.Modules.CustomerService,
PhoenixKit.Modules.Newsletters,
PhoenixKit.Jobs
]

Expand All @@ -35,7 +34,7 @@ defmodule PhoenixKit.ModuleTest do
:ok
end

describe "all 21 modules implement PhoenixKit.Module behaviour" do
describe "all 20 modules implement PhoenixKit.Module behaviour" do
test "all modules are loadable" do
for mod <- @all_internal_modules do
assert Code.ensure_loaded?(mod), "#{inspect(mod)} should be loadable"
Expand Down
Loading