Skip to content

Complete Estonian translation for column-customization UI - #6

Merged
ddon merged 1 commit into
BeamLabEU:mainfrom
timujinne:main
May 11, 2026
Merged

Complete Estonian translation for column-customization UI#6
ddon merged 1 commit into
BeamLabEU:mainfrom
timujinne:main

Conversation

@timujinne

Copy link
Copy Markdown
Contributor

Summary

  • Fill 16 previously-empty Estonian msgstrs in default.po (column-customization UI: Apply / Cancel / Customize columns / Drag to reorder / Selected / Available / etc.)
  • Anchored on the existing Russian translations and the 12 already-translated Estonian entries for terminology consistency

After this commit Estonian default.po is 28/28 translated.

Changes by commit

  • 934e957 — Fill 16 empty Estonian msgstrs in default.po

Test plan

  • mix gettext.merge priv/gettext --locale et clean
  • zero empty msgstr/msgstr[N] (verified)
  • mix format clean
  • Visual check column-customization UI in et locale

priv/gettext/et/LC_MESSAGES/default.po — translate the 16 previously
empty msgstr entries for the column-customization UI (Apply, Cancel,
Customize columns, Drag to reorder, Selected, Available, etc.). Anchored
on the existing Russian translations for meaning and on the previously
translated 12 Estonian entries for terminology consistency.

After this commit Estonian default.po is 28/28 translated (only the
file-header empty msgstr remains, as the PO format requires).

@timujinne timujinne left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR #6 — Complete Estonian translation for column-customization UI

Repo: BeamLabEU/phoenix_kit_crm
Author: @timujinne
Base: mainHead: timujinne:main
Commits: 1 (934e957)
Diff: 1 file, +16 / -16

Verdict: APPROVE

Clean, low-risk translation-only PR. Fills the 16 previously empty Estonian msgstr entries in priv/gettext/et/LC_MESSAGES/default.po for the column-customization UI. After this commit the Estonian default domain is 28/28 translated (only the file-header empty msgstr remains, as required by the PO format).

What changed

# msgid ru (reference) et (PR) Note
1 All columns selected Все столбцы выбраны Kõik veerud valitud OK
2 Apply Применить Rakenda Standard verb form
3 Available Доступные Saadaval OK
4 Cancel Отмена Tühista Standard
5 Click to add Нажмите, чтобы добавить Klõpsa lisamiseks OK (idiomatic, uses translative case)
6 Custom Пользовательские Kohandatud Paired with "Standard → Tavaline"
7 Customize columns Настройка столбцов Kohanda veerge Consistent with "Custom → Kohandatud"
8 Defaults По умолчанию Vaikimisi See note below
9 Drag selected columns to reorder, or click an available column to add it. Перетащите выбранные столбцы для изменения порядка или нажмите на доступный столбец, чтобы добавить его. Lohista valitud veerge järjekorra muutmiseks või klõpsa saadaval oleval veerul selle lisamiseks. Reuses "Selected → Valitud" + "Available → Saadaval" consistently
10 Drag to reorder Перетащите для сортировки Lohista järjekorra muutmiseks Matches fragment in #9
11 No Нет Ei OK
12 No columns selected Столбцы не выбраны Ühtegi veergu pole valitud Idiomatic negation
13 Remove Удалить Eemalda OK
14 Selected Выбранные Valitud OK
15 Standard Стандартные Tavaline OK
16 Yes Да Jah OK

Verification

  • Placeholder safety: ran grep -E '%\{|%\<' priv/gettext/et/LC_MESSAGES/default.po — zero hits. None of the 16 msgids carry interpolation, so no placeholder loss risk.
  • Empty-msgstr count: grep -c 'msgstr ""' …default.po1 (header only, as expected).
  • Consistency check across the 12 already-translated entries + the new 16:
    • "Selected → Valitud" used both standalone (#14) and inside the long sentence (#9).
    • "Available → Saadaval" used both standalone (#3) and inside #9 ("saadaval oleval veerul").
    • "Drag to reorder → Lohista järjekorra muutmiseks" is a clean substring of #9, so the two won't drift.
    • "Custom (Kohandatud) / Standard (Tavaline)" form a coherent pair for the column-preset selector.

Notes (non-blocking)

  • "Defaults → Vaikimisi" is technically an adverb ("by default") rather than a noun plural ("default values"). It is the conventional Estonian UI rendering for a reset-to-defaults action and matches what mainstream Estonian software ships, so it is fine. A literal alternative (Vaikeväärtused / Vaikesätted) would be more pedantic but not better. Keep as-is.
  • "Customize columns / Kohanda veerge" uses the imperative singular (button label), which is the right register for a CTA. Consistent with daisyUI button conventions.

Risk assessment

  • No code changes — pure PO data.
  • No new msgids added, no msgids removed; the diff is exactly 16 paired -msgstr "" / +msgstr "…" lines.
  • No format-spec mismatches possible (no %{…} placeholders involved).
  • CI impact: nil beyond the PO file being re-parsed by gettext.

Suggested merge action

Approve and merge. No follow-ups required.

@ddon
ddon merged commit 1898d53 into BeamLabEU:main May 11, 2026
1 check passed
ddon added a commit that referenced this pull request May 25, 2026
Bump version 0.2.2 -> 0.2.3 and add the CHANGELOG entry covering the
unreleased work: PR #6 (Estonian catalogue completed), PR #7 (CRM admin
page bodies + ColumnManagement flashes localized onto PhoenixKitCRM.Gettext,
settings tab reordered), the dependency refresh (phoenix_kit 1.7.106 ->
1.7.120, ecto 3.13 -> 3.14, others), and the ColumnManagement moduledoc note.

Also format the precommit alias in mix.exs that "libs upgraded" left
unformatted, restoring `mix format --check-formatted`.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants