Complete Estonian translation for column-customization UI - #6
Merged
Conversation
priv/gettext/et/LC_MESSAGES/default.po — translate the 16 previously empty msgstr entries for the column-customization UI (Apply, Cancel, Customize columns, Drag to reorder, Selected, Available, etc.). Anchored on the existing Russian translations for meaning and on the previously translated 12 Estonian entries for terminology consistency. After this commit Estonian default.po is 28/28 translated (only the file-header empty msgstr remains, as the PO format requires).
timujinne
commented
May 11, 2026
timujinne
left a comment
Contributor
Author
There was a problem hiding this comment.
PR #6 — Complete Estonian translation for column-customization UI
Repo: BeamLabEU/phoenix_kit_crm
Author: @timujinne
Base: main ← Head: timujinne:main
Commits: 1 (934e957)
Diff: 1 file, +16 / -16
Verdict: APPROVE
Clean, low-risk translation-only PR. Fills the 16 previously empty Estonian msgstr entries in priv/gettext/et/LC_MESSAGES/default.po for the column-customization UI. After this commit the Estonian default domain is 28/28 translated (only the file-header empty msgstr remains, as required by the PO format).
What changed
| # | msgid | ru (reference) | et (PR) | Note |
|---|---|---|---|---|
| 1 | All columns selected | Все столбцы выбраны | Kõik veerud valitud | OK |
| 2 | Apply | Применить | Rakenda | Standard verb form |
| 3 | Available | Доступные | Saadaval | OK |
| 4 | Cancel | Отмена | Tühista | Standard |
| 5 | Click to add | Нажмите, чтобы добавить | Klõpsa lisamiseks | OK (idiomatic, uses translative case) |
| 6 | Custom | Пользовательские | Kohandatud | Paired with "Standard → Tavaline" |
| 7 | Customize columns | Настройка столбцов | Kohanda veerge | Consistent with "Custom → Kohandatud" |
| 8 | Defaults | По умолчанию | Vaikimisi | See note below |
| 9 | Drag selected columns to reorder, or click an available column to add it. | Перетащите выбранные столбцы для изменения порядка или нажмите на доступный столбец, чтобы добавить его. | Lohista valitud veerge järjekorra muutmiseks või klõpsa saadaval oleval veerul selle lisamiseks. | Reuses "Selected → Valitud" + "Available → Saadaval" consistently |
| 10 | Drag to reorder | Перетащите для сортировки | Lohista järjekorra muutmiseks | Matches fragment in #9 |
| 11 | No | Нет | Ei | OK |
| 12 | No columns selected | Столбцы не выбраны | Ühtegi veergu pole valitud | Idiomatic negation |
| 13 | Remove | Удалить | Eemalda | OK |
| 14 | Selected | Выбранные | Valitud | OK |
| 15 | Standard | Стандартные | Tavaline | OK |
| 16 | Yes | Да | Jah | OK |
Verification
- Placeholder safety: ran
grep -E '%\{|%\<' priv/gettext/et/LC_MESSAGES/default.po— zero hits. None of the 16 msgids carry interpolation, so no placeholder loss risk. - Empty-msgstr count:
grep -c 'msgstr ""' …default.po→1(header only, as expected). - Consistency check across the 12 already-translated entries + the new 16:
- "Selected → Valitud" used both standalone (#14) and inside the long sentence (#9).
- "Available → Saadaval" used both standalone (#3) and inside #9 ("saadaval oleval veerul").
- "Drag to reorder → Lohista järjekorra muutmiseks" is a clean substring of #9, so the two won't drift.
- "Custom (Kohandatud) / Standard (Tavaline)" form a coherent pair for the column-preset selector.
Notes (non-blocking)
- "Defaults → Vaikimisi" is technically an adverb ("by default") rather than a noun plural ("default values"). It is the conventional Estonian UI rendering for a reset-to-defaults action and matches what mainstream Estonian software ships, so it is fine. A literal alternative (
Vaikeväärtused/Vaikesätted) would be more pedantic but not better. Keep as-is. - "Customize columns / Kohanda veerge" uses the imperative singular (button label), which is the right register for a CTA. Consistent with daisyUI button conventions.
Risk assessment
- No code changes — pure PO data.
- No new msgids added, no msgids removed; the diff is exactly 16 paired
-msgstr ""/+msgstr "…"lines. - No format-spec mismatches possible (no
%{…}placeholders involved). - CI impact: nil beyond the PO file being re-parsed by gettext.
Suggested merge action
Approve and merge. No follow-ups required.
ddon
added a commit
that referenced
this pull request
May 25, 2026
Bump version 0.2.2 -> 0.2.3 and add the CHANGELOG entry covering the unreleased work: PR #6 (Estonian catalogue completed), PR #7 (CRM admin page bodies + ColumnManagement flashes localized onto PhoenixKitCRM.Gettext, settings tab reordered), the dependency refresh (phoenix_kit 1.7.106 -> 1.7.120, ecto 3.13 -> 3.14, others), and the ColumnManagement moduledoc note. Also format the precommit alias in mix.exs that "libs upgraded" left unformatted, restoring `mix format --check-formatted`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
After this commit Estonian default.po is 28/28 translated.
Changes by commit
Test plan