handle incomplete MSG_WAITALL during tcp receive#248
Open
Kethen wants to merge 4 commits into
Open
Conversation
…loses the socket cleanly
…ove unused instance of CheckBytes function
Author
|
Added size checks for TCP MSG_WAITALL recv when incoming sizes are known |
|
@Kethen Just tested your most recent changes ! (This was tested on Windows 11) |
Author
Interesting, that'd suggest unlike in WINE, when Windows sees the message, the data it received is truly invalid data How did you reproduce the error in your testing? With the POC server plugin? |
|
@Kethen exactly, I used the POV server plugin ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #185 by handling incomplete TCP recv despite MSG_WAITALL
Fixes running the launcher inside of wine as well as the rare instances where this happens natively.
By creating this pull request, I understand that code that is AI generated or otherwise automatically generated may be rejected without further discussion.
I declare that I fully understand all code I pushed into this PR, and wrote all this code myself and own the rights to this code.