Steam support and other QOL improvements - #5
Merged
Merged
Conversation
- Fixes to some internal functions - Falcon 4.0 support changed for internal functions
There was a problem hiding this comment.
Pull request overview
Adds Steam-based Falcon 4.0 detection/support to the Linux helper installer flow and includes several reliability/QOL improvements around installation, timeouts, desktop integration, and preflight checks.
Changes:
- Add Steam Falcon 4.0 detection/selection and a Steam-based Falcon 4.0 “copy into prefix + registry seed” installation path.
- Improve install robustness with installer argument building, timeout guards, and better runner binary resolution.
- Refresh desktop integration (icon install/refresh + desktop file creation behavior) and refine preflight checks.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| README.md | Updates install instructions to distinguish public vs internal installs and clarify Falcon 4.0 requirements. |
| bms-helper.sh | Implements Steam Falcon 4.0 support, adds installer timeout/arg helpers, refreshes icon/desktop entry handling, and adjusts preflight/install behaviors. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| 3. Place `Falcon BMS_4.38.1_Full_Setup.exe`, `Falcon BMS_4.38.1_Full_Setup.nsisbin` and `setup_falcon_4_2.0.0.1.exe` (from GoG) in the bms-helper extracted folder | ||
| 3. Public install: place `Falcon BMS_4.38.1_Full_Setup.exe`, `Falcon BMS_4.38.1_Full_Setup.nsisbin` and `setup_falcon_4_2.0.0.1.exe` (from GoG) in the bms-helper extracted folder | ||
| 4. Internal install: place the internal Falcon BMS installer package in the helper folder (Falcon 4.0 media is not required) | ||
| 4. Run the `bms-helper.sh`! |
| debug_print continue "Creating ${prefix_desktop_file}..." | ||
| # The backup .desktop file in the prefix directory will always be created so it's up to date | ||
| # Use the configured base dir (public vs internal) when building Exec/Path | ||
| escaped_base_dir="$(echo "$bms_base_dir" | sed "s/\\\\/\\\\\\\\/g; s/'/\\'"/g)" |
Comment on lines
+4236
to
4239
| if [ "$bms_mode" = "public" ]; then | ||
| rm -f -- "$legacy_prefix_desktop_file" "$legacy_localshare_desktop_file" "$legacy_home_desktop_file" | ||
| fi | ||
| rm -f -- "$icon_file" |
Comment on lines
+2208
to
+2214
| elif awk ' | ||
| /^[[:space:]]*#/ { next } | ||
| match($0, /^[[:space:]]*vm\.max_map_count[[:space:]]*=[[:space:]]*([0-9]+)/, m) { | ||
| if (m[1] >= 16777216) found=1 | ||
| } | ||
| END { exit(found ? 0 : 1) } | ||
| ' /etc/sysctl.conf /etc/sysctl.d/* 2>/dev/null; then |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding steam detection and support
Multiple quality of life improvements