Skip to content

Address minor errors from #125 and #170#172

Merged
Benjamin-Lee merged 5 commits intoBenjamin-Lee:masterfrom
agitter:minor-errors
Mar 29, 2019
Merged

Address minor errors from #125 and #170#172
Benjamin-Lee merged 5 commits intoBenjamin-Lee:masterfrom
agitter:minor-errors

Conversation

@agitter
Copy link
Collaborator

@agitter agitter commented Mar 22, 2019

Did you add yourself as a contributor if this is your first contribution?

  • Yes, I added myself or am already a contributor

Any more details?
(see below)

@agitter agitter marked this pull request as ready for review March 22, 2019 10:44
@agitter
Copy link
Collaborator Author

agitter commented Mar 22, 2019

Previous builds had the error ERROR: No anchor #blackbox for internal URI reference (e.g. https://travis-ci.org/Benjamin-Lee/deep-rules/builds/509764376#L2191). Adding a newline after the sub-section header seemed to fix this. @dhimmel is that the expected behavior?

I also switched the CI badge, which was updated in #170 to the new rootstock CI but not the CI for this repository.

Interestingly, it looks like draft pull requests on GitHub don't trigger CI builds on travis-ci.org. It works with the new travis-ci.com GitHub app.

@agitter
Copy link
Collaborator Author

agitter commented Mar 22, 2019

@dhimmel I'm also wondering whether we should revert the ci/deploy.sh changes from travis-ci.org to travis-ci.com.

@agitter agitter requested a review from dhimmel March 22, 2019 11:14
@dhimmel
Copy link
Collaborator

dhimmel commented Mar 22, 2019

Ah yes these two lines are wrong:

deep-rules/ci/deploy.sh

Lines 52 to 53 in 1b43084

https://travis-ci.com/$TRAVIS_REPO_SLUG/builds/$TRAVIS_BUILD_ID
https://travis-ci.com/$TRAVIS_REPO_SLUG/jobs/$TRAVIS_JOB_ID

They should be .org... my bad... have made this mistake in many places.

@dhimmel
Copy link
Collaborator

dhimmel commented Mar 22, 2019

Interestingly, it looks like draft pull requests on GitHub don't trigger CI builds on travis-ci.org. It works with the new travis-ci.com GitHub app.

Drafts do trigger CI on travis-ci.com? IIRC draft PRs haven't triggered any travis builds for me. A real annoying bug. I didn't see an issue here, but we probably should open one.

@dhimmel
Copy link
Collaborator

dhimmel commented Mar 22, 2019

Adding a newline after the sub-section header seemed to fix this. @dhimmel is that the expected behavior?

All the pandoc examples of header identifiers in the docs aren't directly followed by text. It doesn't seem to mention a newline is necessary, but perhaps this is intended. It could also be a pandoc bug.

@agitter
Copy link
Collaborator Author

agitter commented Mar 22, 2019

They should be .org... my bad... have made this mistake in many places.

No problem, updated in fae4239

Drafts do trigger CI on travis-ci.com?

They triggered on this WIP draft pull request gitter-lab/SINGE#13 I'm not sure what we did differently there to get it to work.

@Benjamin-Lee Benjamin-Lee merged commit a7c7713 into Benjamin-Lee:master Mar 29, 2019
Benjamin-Lee added a commit that referenced this pull request Mar 29, 2019
This build is based on
a7c7713.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/Benjamin-Lee/deep-rules/builds/512824962
https://travis-ci.org/Benjamin-Lee/deep-rules/jobs/512824963

[ci skip]

The full commit message that triggered this build is copied below:

Merge pull request #172 from agitter/minor-errors

Address minor errors from #125 and #170
Benjamin-Lee added a commit that referenced this pull request Mar 29, 2019
This build is based on
a7c7713.

This commit was created by the following Travis CI build and job:
https://travis-ci.org/Benjamin-Lee/deep-rules/builds/512824962
https://travis-ci.org/Benjamin-Lee/deep-rules/jobs/512824963

[ci skip]

The full commit message that triggered this build is copied below:

Merge pull request #172 from agitter/minor-errors

Address minor errors from #125 and #170
@agitter agitter deleted the minor-errors branch April 16, 2019 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants