Respect LZ4 end of block conditions - #13
Open
rlespinet wants to merge 1 commit into
Open
Conversation
Lz4js compress can produce outputs that are not conformant with LZ4 official format. This is due to end of block conditions spcified in https://github.com/lz4/lz4/blob/dev/doc/lz4_Block_format.md and more specifically the following: "The last match must start at least 12 bytes before the end of block" For example, prior to this change, when compressing the following string (ASCII encoded) with lz4js "AbcdefghijklmnopAbcdefghijk" a match starting only 11 bytes before the end of the output buffer (corresponding to "Abcdefghijk") would have been created, leading to an invalid output bitstream. Official LZ4 decoder would fail to decompress this bitstream. This commit prevents matches occuring (strictly) less than 12 bytes before the end of the block.
coyotte508
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Mar 13, 2025
The published version of lz4js is outdated, this code also includes a fix from Benzinga/lz4js#13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lz4js compress can produce outputs that are not conformant with LZ4 official format. This is due to end of block conditions spcified in https://github.com/lz4/lz4/blob/dev/doc/lz4_Block_format.md and more specifically the following:
For example, prior to this change, when compressing the following string (ASCII encoded) with lz4js
a match starting only 11 bytes before the end of the output buffer (corresponding to "Abcdefghijk") would have been created, leading to an invalid output bitstream. Official LZ4 decoder would fail to decompress this bitstream. This commit prevents matches occuring (strictly) less than 12 bytes before the end of the block.
Fixes #12