Skip to content
This repository was archived by the owner on Nov 28, 2025. It is now read-only.

[Security] Bump ws from 3.0.0 to 5.2.2#280

Closed
dependabot-preview[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/ws-5.2.2
Closed

[Security] Bump ws from 3.0.0 to 5.2.2#280
dependabot-preview[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/ws-5.2.2

Conversation

@dependabot-preview
Copy link
Copy Markdown

Bumps ws from 3.0.0 to 5.2.2. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Denial of Service in ws Affected versions of ws can crash when a specially crafted Sec-WebSocket-Extensions header containing Object.prototype property names as extension or parameter names is sent.

Proof of concept

const WebSocket = require('ws');
const net = require('net');

const wss = new WebSocket.Server({ port: 3000 }, function () { const payload = 'constructor'; // or ',;constructor'

const request = [ 'GET / HTTP/1.1', 'Connection: Upgrade', 'Sec-WebSocket-Key: test', 'Sec-WebSocket-Version: 8', Sec-WebSocket-Extensions: ${payload}, 'Upgrade: websocket', '\r\n' ].join('\r\n'); </tr></table> ... (truncated)

Affected versions: >= 2.0.0 < 3.3.1

Release notes

Sourced from ws's releases.

5.2.2

Bug fixes

  • Fixed a use after invalidation bug introduced in 6046a28 (8aba871).

5.2.1

Bug fixes

  • Fixed a bug that could prevent buffered data from being processed under certain circumstances (6046a28).

5.2.0

Features

  • Added ability to specify custom headers when rejecting the handshake (#1379).

5.1.1

Bug fixes

  • Fixed a regression introduced in 9e152f9 (#1347).

5.1.0

Features

  • The address argument of the WebSocket constructor can now be a URL instance (#1329).
  • The options argument of the WebSocket constructor now accepts any TLS option that is also accepted by https.request() (#1332).

5.0.0

Breaking changes

  • Dropped support for Node.js < 4.5.0 (#1313).
  • The connection is no longer closed if the server does not agree to any of the client's requested subprotocols (#1312).
  • net.Socket errors are no longer re-emitted (a4050db).

Features

  • Read backpressure is now properly handled when permessage-deflate is enabled (#1302).

4.1.0

Features

  • Added WebSocketServer.prototype.address() (#1294).
  • Added zlib{Deflate,Inflate}Options options (#1306).
Commits
  • 5d55e52 [dist] 5.2.2
  • 8aba871 [fix] Fix use after invalidation bug
  • 175ce46 [dist] 5.2.1
  • 307be7a [fix] Remove the 'data' listener when the receiver emits an error
  • 6046a28 [fix] Do not prematurely remove the listener of the 'data' event
  • bf9b2ec chore(package): update nyc to version 12.0.2 (#1395)
  • bcab531 chore(package): update eslint-plugin-promise to version 3.8.0 (#1389)
  • e4d032c [dist] 5.2.0
  • e7bfe5f chore(package): update mocha to version 5.2.0 (#1385)
  • 6dae94b chore(package): update eslint-plugin-import to version 2.12.0 (#1384)
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Bumps [ws](https://github.com/websockets/ws) from 3.0.0 to 5.2.2. **This update includes a security fix.**
- [Release notes](https://github.com/websockets/ws/releases)
- [Commits](websockets/ws@3.0.0...5.2.2)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview Bot added dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability labels Nov 12, 2020
@dependabot-preview
Copy link
Copy Markdown
Author

Superseded by #288.

@dependabot-preview dependabot-preview Bot deleted the dependabot/npm_and_yarn/ws-5.2.2 branch December 24, 2020 04:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

dependencies Pull requests that update a dependency file security Pull requests that address a security vulnerability

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants