api-gateway settlement listing pagination has no maximum page size - #643
Merged
Conversation
Implement GET endpoint for fetching settlements with pagination and sorting.
|
@0xBernny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request introduces strict defensive safeguards for the settlement listing database queries. It addresses memory-pinning performance risks on the primary database by enforcing max page limits, structured response cursor contracts, and explicit sort schemas.
Key Changes
MAX_PAGE_SIZE = 100). Request criteria asking for out-of-bounds page sizes are automatically clamped down to ensure predictable database load.total,limit,nextCursor,hasMore).createdAt,amount,status,id), returning an explicit422 Unprocessable Entityresponse if an untrusted column vector is injected.Clamped-Size Structural Response Demonstration
When an agent or client hits the endpoint requesting an unrestricted dataset limit size (e.g.,
?limit=50000):{ "data": [ { "id": "set_01", "amount": "250.00", "status": "COMPLETED", "createdAt": "2026-09-03T12:00:00Z" } // ... exactly 99 more items truncated safely ... ], "pagination": { "total": 14205, "limit": 100, "nextCursor": "eyJpZCI6InNldF8xMDAifQ==", "hasMore": true } }Related Issues
Checklist