api-gateway merchant suspension check is checked too late - #645
Merged
Conversation
Implement middleware to check for suspended merchants before request processing.
Added middleware to check merchant suspension before handling routes.
Add unit tests for merchant suspension checks in API.
|
@0xBernny Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses a structural lifecycle vulnerability where merchant suspension validation logic executed too late in the request processing pipeline (occurring after body data parsing and rate-limit evaluation). This allowed suspended identities to consume gateway computation resources and leaked underlying account existence flags.
Key Changes
preHandlerexecution hook (checkMerchantSuspension) processing requests before body schemas enter heavy stream parsing.403 Forbidden(MERCHANT_SUSPENDED) error payload surface across all integrated routing domains.merchant-suspension.test.tsto assertively guarantee execution terminates cleanly at the threshold layer before deep functional processing begins.Lifecycle Interception Verification
When an inbound request targeting a restricted endpoint is intercepted, the route lifecycle timeline verifies premature termination:
Related Issues
Checklist