fix: document execute_recovery permissionless executor policy and add timing tests - #653
Open
Aj-Kayvee wants to merge 1 commit into
Open
fix: document execute_recovery permissionless executor policy and add timing tests#653Aj-Kayvee wants to merge 1 commit into
Aj-Kayvee wants to merge 1 commit into
Conversation
… timing tests Both settlement and governance contracts intentionally skip require_auth on execute_recovery. The recovery target is validated by the recovery address during initiate_recovery, and the 7-day delay provides a window for the current admin set to cancel. Once the delay passes, anyone may execute. Add detailed doc comments explaining this policy and 4 timing/race tests per contract: - execute_recovery_rejects_before_delay (Betta-Pay#9) - execute_recovery_clears_pending_record - execute_recovery_after_cancel_panics (Betta-Pay#8) - execute_recovery_second_call_panics (Betta-Pay#8) Also fixes an unclosed proptest! delimiter in payments.rs and a 5-tuple destructure in admin_tests.rs. Closes Betta-Pay#564
|
@Aj-Kayvee Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564
Problem
in both settlement and governance contracts intentionally requires no authorization from the caller. This is a standard timed-recovery pattern, but the rationale was undocumented and no tests verified the timing constraints:
get_anchor#9) panics before the delay elapsesremove_anchor#8)Solution
Doc comments (settlement + governance )
Added detailed doc comments explaining:
Timing / race tests (4 per contract = 8 total)
Ancillary fixes
Test results