fix: map governance failures to typed error (#482) - #678
Open
Hikmaholadele wants to merge 4 commits into
Open
Conversation
|
@Hikmaholadele Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…min_tests Replace assert_eq!(client.is_paused(), true, ...) with assert!(client.is_paused(), ...) to satisfy clippy::bool_assert_comparison. Run cargo fmt --all for workspace formatting. 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
Contributor
Author
|
Hi, this workflow is currently waiting for maintainer approval. Could you please approve it so the workflow can proceed? Thank you. |
Fix compilation errors from API changes merged from main: - Add missing deployer parameter to init() calls in settlement and governance tests - Fix _env/env variable naming mismatch in governance tests - Fix soroban_sdk::vec! macro syntax in governance tests - Add missing executor parameter to execute() calls in timelock tests - Import GovernanceContract/GovernanceContractClient from governance_contract - Add missing Symbol/Events imports for test assertions - Fix governance FeeConfig type reference - Remove unused imports and prefix unused variables with underscore - Apply cargo fmt formatting across workspace 🤖 Generated with Codebuff Co-Authored-By: Codebuff <noreply@codebuff.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
validate_fee_against_governanceso governance invocation failures return the typedGovernanceCallFailederror instead of causing an unqualified host panic.Changes
Validation
cargo fmt --all -- --checkcargo test --workspaceCloses #482