Skip to content

Conversation

@Bettenoch
Copy link
Owner

@Bettenoch Bettenoch commented Jul 29, 2023

Made the following changes♻:
🔹Refactor code to achieve pure functions (Broke Down code into different modules).
🔸Mock a storage object to "imitate" localStorage operations using "jest-localstorage-mock".
🔹Mock HTML to test if add/delete functions add or remove exactly one li element to/from the list in the DOM.
🔸Create a test functions to check editing, completed and completed status functions.
🔹Adjusted code to pass test.

Thank you for reviewing my repository!!🙏🙏🚀

@Bettenoch Bettenoch changed the title Unit Test Testing Case 1 Jul 29, 2023
Copy link

@victorokoroji victorokoroji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Bettenoch ,

✔️ Status: APPROVED 🏆 🎉 🎊

You have done a great job on this project, keep it up 👍 🥇. Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
congratulations! 🎉💯🌟

Top highlight 🎯

  • The Pull Request is following the GitHub Flow ✅
  • The PR title and description are professional and descriptive ✅
  • Test cases covered ✅
  • All tests passed ✅

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants