Skip to content

chore(android): ignore generated Android build output - #2353

Closed
guerrini wants to merge 2 commits into
BetterAngelsLA:mainfrom
guerrini:chore/ignore-android-build-output
Closed

guerrini wants to merge 2 commits into
BetterAngelsLA:mainfrom
guerrini:chore/ignore-android-build-output

Conversation

@guerrini

@guerrini guerrini commented Aug 20, 2026

Copy link
Copy Markdown

expo prebuild / run:android generate apps/betterangels/android/ and
per-module android/build/ directories. Without these entries a local Android
build leaves thousands of untracked files in git status.

The expo-splash-screen dependency that originally accompanied this fix is
already on main, so only the ignore rules remain.

Split out from in-progress referral module work so the build fix can land on its
own. No behaviour change — four lines added to .gitignore, nothing else.

Summary by Sourcery

Build:

  • Ignore generated Android project and build output to keep local prebuild and Android build artifacts out of version control.

`expo prebuild` / `run:android` generate apps/betterangels/android/ and
per-module android/build/ directories. Without these entries a local
Android build leaves thousands of untracked files in `git status`.

The expo-splash-screen dependency that originally accompanied this fix is
already on main, so only the ignore rules remain.
@sourcery-ai

sourcery-ai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adds .gitignore entries to exclude generated Android build output directories from version control, avoiding thousands of untracked files after running Expo Android build commands.

File-Level Changes

Change Details Files
Ignore generated Android/Expo build artifacts so local Android builds do not produce untracked files.
  • Add ignore rule for the generated apps/betterangels/android/ directory created by Expo prebuild/run:android.
  • Add ignore rules for per-module android/build/ directories produced during Android builds.
  • Scope the ignore patterns narrowly to Android build output paths to avoid unintended exclusions.
  • Leave all other ignore rules and project files unchanged; this change is limited to four new lines in the root .gitignore.
.gitignore

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@guerrini guerrini changed the title chore: ignore generated Android build output chore(android): ignore generated Android build output Aug 20, 2026
@guerrini

Copy link
Copy Markdown
Author

Superseded by #2466, opened from a branch in this repository.

@guerrini guerrini closed this Sep 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants