Skip to content

Add a review rule for specs that cannot fail usefully - #50

Merged
bockets merged 2 commits into
mainfrom
propose-useless-spec-review-rule
Sep 10, 2026
Merged

Add a review rule for specs that cannot fail usefully#50
bockets merged 2 commits into
mainfrom
propose-useless-spec-review-rule

Conversation

@bockets

@bockets bockets commented Sep 8, 2026

Copy link
Copy Markdown
Member

Adds a shared rule block, prompts/_shared/spec-value-rules.md, asking the review to judge the specs a diff adds or changes.

The definition: a spec is useless if its failure would neither reveal a regression worth fixing nor point at what to fix. The first half rules out the spec that cannot go red. The second rules out the spec that goes red on everything and explains nothing.

Two deliberate limits:

  • It never blocks. A useless spec is reported and the PR is still approved unless another finding blocks. Test value is a judgment call.
  • It carries a do-not-flag list. Regression specs for fixed bugs, edge and nil-path examples, the required flag-on/flag-off pair, and missing coverage are all named as not this finding. Without that, the likely failure is the review asking to delete specs that look redundant and are not.

Wired into all three prompts so the stages cannot drift, which bumps each prompt's content-derived version.

Same definition proposed for the app repo's CLAUDE.md: BiggerPockets/biggerpockets#30942

@bockets
bockets force-pushed the propose-useless-spec-review-rule branch from 2b508d1 to 637a1d2 Compare September 10, 2026 19:26
@bockets
bockets marked this pull request as ready for review September 10, 2026 19:26
@bockets
bockets merged commit 87c6881 into main Sep 10, 2026
1 check passed
@bockets
bockets deleted the propose-useless-spec-review-rule branch September 10, 2026 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant