Add a review rule for specs that cannot fail usefully - #50
Merged
Conversation
bockets
force-pushed
the
propose-useless-spec-review-rule
branch
from
September 10, 2026 19:26
2b508d1 to
637a1d2
Compare
bockets
marked this pull request as ready for review
September 10, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a shared rule block,
prompts/_shared/spec-value-rules.md, asking the review to judge the specs a diff adds or changes.The definition: a spec is useless if its failure would neither reveal a regression worth fixing nor point at what to fix. The first half rules out the spec that cannot go red. The second rules out the spec that goes red on everything and explains nothing.
Two deliberate limits:
Wired into all three prompts so the stages cannot drift, which bumps each prompt's content-derived version.
Same definition proposed for the app repo's
CLAUDE.md: BiggerPockets/biggerpockets#30942