[no-ticket] Flag blocking web requests in favour of background jobs - #51
Merged
Conversation
bockets
marked this pull request as ready for review
September 8, 2026 15:56
The reviewer had no rule about work whose cost grows with the request's input. A controller that loops over an uploaded file's rows creating a record each, with the model callbacks that implies, reads as ordinary code in a diff and times out in production once somebody uploads a real portfolio. This adds the rule, injected into all three prompts alongside the existing performance block. It draws the line at cost that grows with something the request does not control -- rows in a file, items a client sent, matches from a query -- rather than at "slow", and asks for the two things a request-to-job move has to get right: progress the member can actually see, and a perform that is safe to run twice, since a deploy SIGTERM will run it twice.
bockets
force-pushed
the
flag-blocking-web-requests
branch
from
September 10, 2026 18:49
66fd46e to
2b797c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[no-ticket]
The reviewer flags N+1s and batch/task hot spots, but nothing about work whose
cost grows with what the request was handed. A controller that loops over an
uploaded file's rows creating a record each passes every existing rule and times
out in production the first time somebody uploads a real file.
Adds
prompts/_shared/blocking-request-rules.md, injected into all threeprompts next to the existing performance block. The line is cost that grows with
something the request does not control, not "slow". It also treats two things as
findings when a request-to-job move misses them: determinate server-recorded
progress with a readable failure state, and a
performthat is safe to retry.Exclusions cover bounded work, anything already off the request path, and a
synchronous call the response depends on.
Prompt versions derive from file content, so every consuming repo picks this up
at once.