Add email-deliverability (MX lookup) rule to review prompts - #55
Merged
Conversation
Reviewers must now flag any code that accepts an email address without checking the domain's MX records first, so the address is deliverable. Sole exception: logging-only collection where no message will be sent.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new shared rule block,
prompts/_shared/email-deliverability-rules.md, and wires it into all three review prompts (Codex first pass, Claude synthesize control, and Claude synthesize thesis-first) as the step immediately after the member-privacy rules.The rule requires reviewers to flag, as a blocking finding, any code that lets an email address be added — form field, API endpoint, admin/console path, import, mailing list signup — without first doing an MX record lookup on the address's domain to confirm the address is deliverable.
The sole exception
The MX lookup is not required when the code is only logging that the email exists — e.g. stashing an address observed in a third-party payload for the record — and nothing in the change (or in code consuming what it stores) intends to send an actual message to that address.
Notes on scope
scripts/resolve-prompts.sh, so this change rolls all prompt versions automatically.