Skip to content

more lexxy darkmode fixes - #47

Merged
BillyRuffian merged 1 commit into
mainfrom
feature/lexxy-dark-mode-2
Jan 7, 2026
Merged

more lexxy darkmode fixes#47
BillyRuffian merged 1 commit into
mainfrom
feature/lexxy-dark-mode-2

Conversation

@BillyRuffian

Copy link
Copy Markdown
Owner

No description provided.

Copilot AI review requested due to automatic review settings January 7, 2026 21:37
@BillyRuffian
BillyRuffian merged commit 66fa9a8 into main Jan 7, 2026
8 checks passed

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds comprehensive dark mode support to the Lexxy editor by implementing CSS media query overrides and updating table styling to properly adapt to dark color schemes.

  • Introduces dark mode color variables via prefers-color-scheme media query
  • Updates table header and cell styling to use new dark-mode-aware CSS variables
  • Ensures proper color inheritance and background colors throughout the editor components

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
app/assets/stylesheets/lexxy-variables.css Adds dark mode CSS variable overrides for colors, including ink, accent, code token, and table colors with a new @media (prefers-color-scheme: dark) block
app/assets/stylesheets/lexxy-content.css Updates table header styling to use the new --lexxy-color-table-header-bg variable for consistent dark mode support
app/assets/stylesheets/application.bootstrap.scss Enhances table styling within lexxy editor contexts to properly apply dark mode colors, including header cells, regular cells, and selected states with explicit background color declarations

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

width: unset;
inline-size: calc(100% - 0.5ch);
margin: 0.25ch;

Copilot AI Jan 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove trailing whitespace at the end of this line.

Suggested change

Copilot uses AI. Check for mistakes.
--lexxy-color-ink: #e9ecef;
--lexxy-color-ink-medium: #adb5bd;
--lexxy-color-ink-light: #6c757d;
--lexxy-color-ink-lighter: #6c757d;

Copilot AI Jan 7, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The variables --lexxy-color-ink-light and --lexxy-color-ink-lighter are both set to the same color value #6c757d. These variables should represent different lightness levels in the dark mode color scheme. Consider adjusting one of these values to maintain the intended color hierarchy, similar to how they differ in the light mode (lines 5-6).

Suggested change
--lexxy-color-ink-lighter: #6c757d;
--lexxy-color-ink-lighter: #868e96;

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants