Skip to content

Web components#24

Merged
tib merged 9 commits into
mainfrom
feature/magic
Mar 6, 2026
Merged

Web components#24
tib merged 9 commits into
mainfrom
feature/magic

Conversation

@tib
Copy link
Copy Markdown
Member

@tib tib commented Mar 6, 2026

  • component basics
  • component tests
  • fix format
  • fix readme

@tib tib requested review from GErP83 and nNBee March 6, 2026 15:41
@tib tib merged commit 37c6fa1 into main Mar 6, 2026
16 of 17 checks passed
@tib tib deleted the feature/magic branch March 6, 2026 22:56
@mynona
Copy link
Copy Markdown
Contributor

mynona commented May 2, 2026

Hi, when will there be a release to use this new swift-html repo?

@tib
Copy link
Copy Markdown
Member Author

tib commented May 4, 2026

I think we could start doing the beta cycle... I'm going to release some other brand new stuff today, I'll tag this one too. :)

@mynona
Copy link
Copy Markdown
Contributor

mynona commented May 9, 2026

Hi @tib
Unfortunately you do not allow the Issues tab

I started the migration and immediately run into an issue with a missing package target

initializer 'init(dictionaryLiteral:)' is not available due to missing import of defining module 'OrderedCollections'

.product(name: "OrderedCollections", package: "swift-collections"),

.target(
name: "SGML",
dependencies: [
.product(name: "OrderedCollections", package: "swift-collections"),
// ...other dependencies...
]
)

this is used in the AttributeStore

import OrderedCollections

Errors with OrderedDictionary

if I am not wrong
import Collections ≠ import OrderedCollections

@mynona
Copy link
Copy Markdown
Contributor

mynona commented May 9, 2026

If this finding is correct, can you please publish a new beta?

@mynona
Copy link
Copy Markdown
Contributor

mynona commented May 9, 2026

and one more finding it seems Style cannot be nested

@builder
public func render(_ request: Request) -> [Element] {

MasterFrontend(
  .init(
    seo: context.seo,
    matomoStatus: context.matomoStatus,
    matomoPageType: context.matomoPageType,
    authenticatedUserID: context.authResult.authenticatedUserID?.uuidString
  )
) {

  Body {

    // MARK: x-cloak
      Style("[x-cloak] { display: none !important; }") 

i would need to add

Style("[x-cloak] { display: none !important; }") as! FlowContent

@mynona
Copy link
Copy Markdown
Contributor

mynona commented May 9, 2026

and last one then i will stop and wait first to see how you would like to deal with reported issues

Link(rel: .preconnect)
.href("https://www.raumnebenan.de")
.crossorigin(.anonymous)

                crossorigin is missing in link
                
                i can extend LInk but I think this is also a generic behavior

but apart from those smaller things first migration attempt went smooth and those are the immediate findings

hope it helps & thanks for providing the web standards repo :-)

@tib
Copy link
Copy Markdown
Member Author

tib commented May 9, 2026

Issues are now open, sorry about that. Would you mind moving those comments over? So we can discuss them properly. Many thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants