feat: rewrite bubble layout as vertical stack#5
Merged
Conversation
Drop the orbital BubbleLayout in favor of a bottom-up vertical stack pinned to the pet (max 5 visible). The orbital layout required a 1100x800 stage to avoid clipping the worst-case expanded card, which detached the window from any natural anchor; the stack collapses the stage to 380x620 and lets PetWindow constrain its frame to visibleFrame so the seal cannot leave the screen. Bubbles always render as pixel-style cards; the collapsed dot form is gone. Default card shows cwd / title and the last assistant message extracted from the transcript via the Stop hook. Drop PersistentStore: cross-run "recent session" restore produced ghost cards more often than it helped, since the only liveness signal was a 10-minute timer. Stale-peer pruning now keys on isRunning + lastActivityAt, so legitimate parallel sessions in the same cwd survive. Disconnect monitoring on the IPC channel is lazy-attached when onPeerDisconnect is registered, closing a race where EOF arrived before the @mainactor handler bound. askUser disconnect now advances via askUserResolved -- the state machine has no askUser -> postToolUse edge. See devDocs/hooks-and-priority.md for the Stop hook payload.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop the orbital BubbleLayout in favor of a bottom-up vertical stack pinned to the pet (max 5 visible). The orbital layout required a 1100x800 stage to avoid clipping the worst-case expanded card, which detached the window from any natural anchor; the stack collapses the stage to 380x620 and lets PetWindow constrain its frame to visibleFrame so the seal cannot leave the screen.
Bubbles always render as pixel-style cards; the collapsed dot form is gone. Default card shows cwd / title and the last assistant message extracted from the transcript via the Stop hook.
Drop PersistentStore: cross-run "recent session" restore produced ghost cards more often than it helped, since the only liveness signal was a 10-minute timer. Stale-peer pruning now keys on isRunning + lastActivityAt, so legitimate parallel sessions in the same cwd survive.
Disconnect monitoring on the IPC channel is lazy-attached when onPeerDisconnect is registered, closing a race where EOF arrived before the @mainactor handler bound. askUser disconnect now advances via askUserResolved -- the state machine has no askUser -> postToolUse edge.
See devDocs/hooks-and-priority.md for the Stop hook payload.