Add CI-ready tx-path integration suite and CI/Makefile wiring#62
Merged
Add CI-ready tx-path integration suite and CI/Makefile wiring#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
X-TX-TOKEN) when available.Description
scripts/tests/tx_integration.sh, a strict-mode bash script that boots or reuses a devnet, waits for RPC readiness, discovers chain id, resolves a sender key (SENDER_PRIVATE_KEY→FAUCET_PRIVATE_KEY→ dev-only.datadiscovery), and runs three tx checks (send 1 wei to burn address, deploy minimal test contract, submit explicit raw signed tx) with receipt polling and assertion logic.rpc_call,rpc_get_result,wait_for_receipt,get_nonce,get_gas_price,estimate_gas, local signing via a temporary Node+ethers workspace, and UI vs raw-RPC mode selection with clear failure whenTX_HTTP_URLis set butTX_TOKENis missing.test-txandtest-allMakefile targets and makemake testoptionally include tx tests whenCI_TX=1, and updatescripts/ci/run.shto run the tx suite whenCI_TX=1.CI_TX=1and expose optional secrets placeholders (SENDER_PRIVATE_KEY,FAUCET_PRIVATE_KEY,TX_HTTP_URL,TX_TOKEN) without hardcoding values, and document usage and skip/fail behavior inREADME.md.Testing
bash -n scripts/tests/tx_integration.sh(syntax check) succeeded.make test-txwas exercised in this environment but failed during the repo build step due to inability to fetch/buildpolygon-edge(external GitHub clone failed withCONNECT tunnel failed, response 403), which is an external network issue unrelated to the new tx test logic.Codex Task