Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b94ae41cff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| let healthy = nodesUp > 0 && nodesSealing > 0; | ||
| let reason = 'At least one node is up and sealing.'; | ||
| let healthy = nodesUp > 0; |
There was a problem hiding this comment.
Keep health checks dependent on block progress
summarize now marks the system healthy as soon as any RPC endpoint is reachable, which means /healthz can return 200 even when the chain is stalled (RPC responds but eth_blockNumber is not advancing). In that outage mode, monitoring and CI gates that rely on /healthz will get false positives; the prior behavior required evidence of sealing before reporting healthy.
Useful? React with 👍 / 👎.
Motivation
make lintand CI linting resilient and actionable when developer machines/containers are missinggo.sumentries, while still enforcing strict checks in CI.Description
apps/status-ui/server.jsto preferSTATUS_UI_PORToverPORTandSTATUS_UI_HOSToverHOST, log the bind host/port and RPC count, and introducedRPC_TIMEOUT_MSfor per-RPC request timeouts.RPC_URLS(comma-separated) with fallback toRPC_URL, defaulting to the 4-node devnethttp://127.0.0.1:8545..:8548; each RPC is polled in parallel (eth_blockNumber,net_peerCount, optionaleth_chainId), errors/timeouts are captured per-node, and returned node objects usereachable,ethBlockNumber,netPeerCount, andchainId.apps/status-ui/public/index.htmlto render one card per configured RPC and to displayreachable/unreachable, RPC label,eth_blockNumber,net_peerCount,chainId, and last error.STATUS_UI_HOST,STATUS_UI_PORT,RPC_URLS, andCI_LINT_STRICTdefaults;status-uitarget now passesSTATUS_UI_HOST/STATUS_UI_PORT/RPC_URLSexplicitly and writes a proper PID;stop-ui/status logic preserved with best-effort kill+SIGKILL.go vetfailures caused by missinggo.sumentries: it prints guidance and only fails whenCI_LINT_STRICT=1.CI_LINT_STRICT=1is set for GitHub Actions andscripts/ci/run.shruns lint early;scripts/tests/integration.shupdated to use the new status-ui port/env names.STATUS_UI_HOST,STATUS_UI_PORT,RPC_URLS,RPC_TIMEOUT_MS) and example overrides.Testing
make lint(local mode,CI_LINT_STRICT=0): produced the expectedgo vetwarnings about missinggo.sumentries and exited successfully with a clear guidance message. (succeeded, warning printed)CI_LINT_STRICT=1 make lint:go vetfailures due to missinggo.sumcaused lint to fail as designed. (failed as expected in strict mode)make test-unit: failed in this environment due to missinggo.sumdependency checksum issues reported by Go toolchain (observed and reported). (failed due to environment dependency checksums)make status-ui/make status-ui-status/make stop-uilifecycle: server started (logged bind and rpc count), PID file behavior and stop path tested; calling/api/statusagainst a manual server run reportedconfiguredRpcs=4and returned 4 node entries (one per RPC). (status-ui behavior verified)ERR_EMPTY_RESPONSEin this environment, andnpmmay fail under restrictive registry/proxy policies, so somemake status-uiruns can fail to install packages here (network/registry policy related). (environment-dependent)Codex Task