Skip to content

Fix typo modelMatrix -> model_matrix#23

Merged
dannda merged 1 commit intoBioNGFF:mainfrom
will-moore:fix_model_matrix
Aug 28, 2025
Merged

Fix typo modelMatrix -> model_matrix#23
dannda merged 1 commit intoBioNGFF:mainfrom
will-moore:fix_model_matrix

Conversation

@will-moore
Copy link
Copy Markdown
Contributor

Description

This fixes a bug where the dataset.coordinateTransformations from the OME-Zarr metadata were getting ignored.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • All tests pass (eg. npm test)
  • Pre-commit hooks run successfully (eg. pre-commit run --all-files)

To test:

  • Try these 2 samples (from discussion at Multi sources with transforms hms-dbmi/vizarr#259) source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0101A/13457227.zarr&source=https://uk1s3.embassy.ebi.ac.uk/idr/zarr/v0.4/idr0101A/13457537.zarr
  • Without this PR, they are both aligned to the same top-left corner.
  • With this PR, the smaller image is offset in x, y and z. When fully zoomed in, the smaller image actually disappears in Z, but if you zoom out, it will appear. It's also easier to see if you reduce opacity of the bigger image:
Screenshot 2025-08-22 at 14 43 04

@dannda dannda merged commit c3a3135 into BioNGFF:main Aug 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants