Transformations0.5#76
Draft
AlexSurtees wants to merge 2 commits intodevfrom
Draft
Conversation
❌ Deploy Preview for biongff-vizarr failed.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Basically a lot of abstraction/refactoring to allow transformations to come from a different place in the source data, then reading the image level transformations e.g. multiscale.coordinateTransformations and resolution level transformations (multiscales.datasets.coordinateTransformations) and applying them in the correct order (resolution-level -> image-level according to the specification).
Basically has no impact on the viewer (only scale and translation are supported in 0.5 and the image is always centred in the viewer), but lays the groundwork for the upcoming 0.6 scenes specification and new coordinateSystems/coordinateTransformations metadata format.
Note that this carries over the existing behaviour of seemingly only applying the first resolution-level transformation.
Type of change
Checklist
npm test)pre-commit run --all-files)