Use names= rather than .Names= in structure() - #257
Open
Bisaloo wants to merge 1 commit into
Open
Conversation
The latter returns the following warning: Warning in structure(msg, .Names = tail(as.character(cl), 1L)) : Replacing special names ‘.Names’ is deprecated; use ‘names’ instead. Introduced in r-devel/r-svn@ec9dbae.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #257 +/- ##
=======================================
Coverage 69.17% 69.17%
=======================================
Files 15 15
Lines 3046 3046
=======================================
Hits 2107 2107
Misses 939 939 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The latter returns the following warning:
Introduced in r-devel/r-svn@ec9dbae.
Should this get a NEWS bullet?
As an aside, I would find
setNames()slightly more readable so if you agree, I'm happy to add a new commit for that.