Skip to content

Localization for Buttons and missing lang key. #23

Description

@KameiB

For Minecraft 1.12.2.
RecommendJarStep.class
init method
Both "PressableButton" instantiations are using hardcoded texts instead of lang keys.

new PressableButton(1, screen.width / 2 - 104, screen.height / 2 + 20, 100, 20, "Select", (b)
and
new PressableButton(2, screen.width / 2 + 4, screen.height / 2 + 20, 100, 20, "Change", (b)

Guess you forgot to create:

private final String selectButton = I18n.format("step.recommended_jar.select");
private final String changeButton = I18n.format("step.recommended_jar.change");

and then call:
new PressableButton(1, screen.width / 2 - 104, screen.height / 2 + 20, 100, 20, selectButton, (b)
and
new PressableButton(2, screen.width / 2 + 4, screen.height / 2 + 20, 100, 20, changeButton, (b)

Also, I don't see these lang keys defined in the .lang file:

server_entry.title=Order Server
server_entry.description=Let's create your Minecraft Server.

Edit: Sorry I just read your server_creator_banner description 😅

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions