Skip to content
This repository was archived by the owner on Dec 7, 2023. It is now read-only.

[AT-1463] add license to shaded jar file - #33

Open
RoyZhang2022 wants to merge 3 commits into
mainfrom
royzhang2022/AT-1463/license_in_shaded_jar
Open

RoyZhang2022 wants to merge 3 commits into
mainfrom
royzhang2022/AT-1463/license_in_shaded_jar

Conversation

@RoyZhang2022

@RoyZhang2022 RoyZhang2022 commented Jul 20, 2023

Copy link
Copy Markdown

Summary:
Add license used in the JDBC driver to the shaded jar

Description:

  • The license file needs to be under jdbc/src/main/resources/META-INF so it could be included in the shaded jar automatically when jar is built.
  • Copy THIRD-PARTY-LICENSES.txt to jdbc/src/main/resources/META-INF in pom.xml when mvn build starts
  • Add jdbc/src/main/resources/META-INF/THIRD-PARTY-LICENSES.txt to .gitignore to avoid it to be added to git repo as it is only for build purpose.

Test:

  • Run jar -xf amazon-timestream-jdbc-2.0.0-shaded.jar to extract. TheTHIRD-PARTY-LICENSES.txt could be found under directory META-INF.
  • Test the shaded jar using DbVisualizer, the JDBC connection creation and queries could run successfully.

Issue:
https://bitquill.atlassian.net/browse/AT-1463

@dkovalenkoI dkovalenkoI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants