This repository was archived by the owner on Dec 7, 2023. It is now read-only.
[AT-1463] add license to shaded jar file - #33
Open
RoyZhang2022 wants to merge 3 commits into
Open
RoyZhang2022 wants to merge 3 commits into
RoyZhang2022 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Add license used in the JDBC driver to the shaded jar
Description:
jdbc/src/main/resources/META-INFso it could be included in the shaded jar automatically when jar is built.THIRD-PARTY-LICENSES.txttojdbc/src/main/resources/META-INFin pom.xml when mvn build startsjdbc/src/main/resources/META-INF/THIRD-PARTY-LICENSES.txtto .gitignore to avoid it to be added to git repo as it is only for build purpose.Test:
jar -xf amazon-timestream-jdbc-2.0.0-shaded.jarto extract. TheTHIRD-PARTY-LICENSES.txtcould be found under directoryMETA-INF.Issue:
https://bitquill.atlassian.net/browse/AT-1463