Fix EXPECT_EQ() to have expected on the left and actual on the right - #117
Merged
Merged
Conversation
alinaliBQ
reviewed
Oct 6, 2025
alinaliBQ
reviewed
Oct 6, 2025
justing-bq
force-pushed
the
expectVsActual
branch
from
October 6, 2025 19:30
62c9db2 to
adc7d46
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Google Test assumes that
EXPECT_EQ()has the expected value as the left argument and the actual value as the right argument so we are fixing the tests to be consistent with this.What changes are included in this PR?
Ensured that
EXPECT_EQ()has the expected value as the left argument and the actual value as the right argument.Are these changes tested?
N/A
Are there any user-facing changes?
No.