feat(editor): favorites strip and tested catalog filters (#29) - #353
Open
Aduersarius wants to merge 1 commit into
Open
feat(editor): favorites strip and tested catalog filters (#29)#353Aduersarius wants to merge 1 commit into
Aduersarius wants to merge 1 commit into
Conversation
) Fill the remaining Bitcoindefi#29 “favoritos o recientes” gap on top of the merged Stage 4 palette: star favorites with localStorage, FavoritesStrip re-select, and pure catalogFilter helpers covered by node:test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses remaining #29 acceptance after Stage 4 landed via #109: the issue asked for favoritos o recientes, and main only had recientes.
★favorites on objects / NPCs / terrain tiles (persisted inlocalStorageaseditor.favorites.v1)FavoritesStripon/construccionfor one-click re-select across sessionsfrontend/lib/editor/catalogFilter.tshelpers (search, type filter, counts, toggle/parse favorites)node --test --experimental-strip-types frontend/lib/editor/catalogFilter.test.ts(10/10)Refs #29 (issue already closed by #109; this is the favorites gap fill).
Differentiation vs open PRs
AssetPaletteBrowser): mock catalog (Objeto #i), pagination, GRH text placeholders, plus kitchen-sink protocol/map-converter churn. This PR builds on the real merged/construccioneditor with realgrhIndexpreviews and virtualized lists — no unrelated packages.ContentBrowseron/play): different surface (play HUD + temporary server placement). This PR extends the admin construction editor that already ships object/NPC/terrain placement with persistence hooks.Test plan
cd frontend && node --test --experimental-strip-types lib/editor/catalogFilter.test.ts/construccionas game-data admin → star an object/NPC/tile → FavoritesStrip shows it after reloadNo txs/keys/funds involved.