feat(server): classic WorldEditor map import/export to mapas_source (#23) - #356
Open
Aduersarius wants to merge 1 commit into
Open
feat(server): classic WorldEditor map import/export to mapas_source (#23)#356Aduersarius wants to merge 1 commit into
Aduersarius wants to merge 1 commit into
Conversation
…itcoindefi#23) Clean-room .map/.inf/.dat converter targeting playable OpenAO mapas_source (meta/terrain/specials/npcs), with explicit untranslated reports, round-trip validation, CLI, tests, and AGPL licensing notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships OpenAO #23: clean-room import/export between classic desktop WorldEditor files (
.map/.inf/.dat) and playable OpenAOmapas_source(meta.json,terrain.json,specials.json,npcs.json).server/src/lib/worldEditorMapConverter.tsserver/src/scripts/worldEditorMapImportExport.ts(import/export/validate).datkeys, uncommon triggers, particle/light flags, GRH > Int16)server/src/tests/worldEditorMapConverter.test.ts(4/4)docs/worldeditor-map-import-export.md+docs/licensing-notes.md(no VB6 WorldEditor source copied)Closes #23
Differentiation vs open PRs
MapDatainfrontend/utils/+ ad-hoc.mjstest script. This PR writes the servermapas_sourcetree the game already loads, includingnpcs.json, plus a real CLI validate mode..map-only tool bundled with unrelated protocol/FE kitchen-sink. This PR is #23-only, covers.map+.inf+.dat, and reports extended flags that cannot map into OpenAO.legacyMapConverter. This PR is single-issue, reviewable, and targets the full acceptance list (import report, export, validate, license docs, tests).Test plan
node --experimental-strip-types --test server/src/tests/worldEditorMapConverter.test.ts(4/4)tsx src/scripts/worldEditorMapImportExport.ts export --map-id=1 --source-dir=server/mapas_source --classic-dir=/tmp/classic-outtsx src/scripts/worldEditorMapImportExport.ts import --map-id=1 --classic-dir=/tmp/classic-out --output-dir=/tmp/mapas_imported --prettytsx src/scripts/worldEditorMapImportExport.ts validate --map-id=1 --source-dir=server/mapas_sourcemapa_1loads via existingloadMapspathNo txs/keys/funds involved.