"Repeat Registration" functionality for plug-in assemblies#55
Open
MattTrinder1 wants to merge 4 commits intoBiznamics:masterfrom
Open
"Repeat Registration" functionality for plug-in assemblies#55MattTrinder1 wants to merge 4 commits intoBiznamics:masterfrom
MattTrinder1 wants to merge 4 commits intoBiznamics:masterfrom
Conversation
Collaborator
|
I may be misunderstanding this, but it sounds like it does pretty much what the Plugin Auto Deployer does? This is found in the tool package called Innofactor Tools. |
Author
|
Err, yep it does :-) I was unaware of the auto updater. I’ll have a play with that over the next couple of days. I still think this is a useful update to the PRT though. |
Collaborator
|
@MattTrinder1 - Yep * 2 😊 |
rappen
requested changes
Aug 21, 2019
Collaborator
rappen
left a comment
There was a problem hiding this comment.
A few comments to the code:
- Changed/Added method signatures to not follow the code style of space after comma. This is also true for some of the code added. This is solved by a simple +K+D in the code.
- I don't see why the three new properties should be declared as public, assuming private would be enough? Also I don't see the reason for having them spread around the code, instead of placing them together at the top with other declarations.
- New method to handle button click is not placed within proper region.
- Instead of re-using button click methods, it would probably be better to extract the functionality to separate methods being called. This would probably also remove the need for the added property
AssemblyFileName.
Author
|
Tidied up as requested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Adds a "Repeat" button to the toolbar which repeats the previous registration, preventing the need to display the form, select the same assembly etc. Uses the existing functionality from the registration form.
A bit rough and ready but seems to work OK.