Away mode, and a library of chores to pick from - #13
Merged
Conversation
Two features aimed at the two moments households give up on a chore app: the empty screen on day one, and coming home from holiday. Away mode does two things, and the second is the one that matters. Chores stop being assigned to you - obvious - and your expected share shrinks in proportion to the days you were gone. Pausing assignment alone would leave someone returning from a fortnight away to an app announcing they were behind, which is both false and precisely the accusation this app exists not to make. That falls out of the existing maths for free. Being away produces an effective weight, and the fairness scoring already understands members having different weights, so the scoring itself needed no changes at all. There is a test proving the case: Ana here all month doing 20 points, Ben away half of it doing 10, scores 95+. Without the scaling it would score 33 and tell Ben he was slacking. If everybody is away, assignment falls back to the whole household. Better that somebody has the bins than that they are nobody's problem. The template library is thirty-odd chores grouped by room, with opinionated effort values and cadences. Setting up is where households abandon these apps: an empty screen asks you to do the hardest part, remembering everything your home needs, before the app has earned any trust. Ticking a list is a different and far easier task, and the list doubles as a prompt for the jobs nobody thinks to write down. Chores you already have are shown disabled rather than hidden, so the list stays a complete picture. 24 new tests, 197 total. Lint, typecheck and build clean; all five routes verified against the running server.
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two features aimed squarely at the two moments households give up on a chore app: the empty screen on day one, and coming home from holiday.
Away mode
Tell chorely you're away for a weekend, a week, a fortnight or a month. Two things happen:
The second is the one that matters. Pausing assignment alone would leave someone returning from a fortnight away to an app announcing they were behind — both false, and precisely the accusation this project exists not to make.
Pleasingly, that falls out of the existing maths for free. Being away produces an effective weight, and the fairness scoring already understands members having different weights — so the scoring itself needed no changes whatsoever.
There's a test for exactly the case that motivated it: Ana here all month doing 20 points, Ben away for half of it doing 10. That's even, and it scores 95+. Without the scaling it scores 33 and tells Ben he's slacking.
Two edges worth noting:
The chore library
Thirty-odd chores grouped by room — kitchen, bathroom, living space, bedroom, household, pets — with opinionated effort values and cadences.
Setting up is where households abandon these apps. The empty screen asks you to do the hardest part — remember everything your home needs — before the app has earned any trust at all. Ticking boxes is a different and much easier task, and the list doubles as a prompt for the jobs nobody thinks to write down (sorting the post, cleaning the oven, the second bin day).
Chores you already have are shown disabled rather than hidden, so the list stays a complete picture of what a home might need rather than quietly shrinking.
Templates can carry a note — "check which bin it is this week" — into the chore they create, which pairs with the notes feature from the last PR.
Verified
24 new tests (197 total), covering the fairness scaling, the assignment skip, the not-yet-started period, the everyone-away fallback, and that someone back from holiday is held to their full share again.
Lint, typecheck and build clean. All five routes and both new interfaces confirmed against the running server, zero server errors.