Skip to content

16 subtitle conversion library #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sjiamnocna wants to merge 15 commits into
base: master
Choose a base branch
from
Open

16 subtitle conversion library #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
fc58d4c
Adding basic library for paralell pipe processing of subtitles
sijanced Jul 15, 2025
18347b5
Generating valid subtitles
sijanced Jul 16, 2025
7d7ab81
Tests passing
sijanced Jul 17, 2025
2a557cc
Tests passing, reversing in the end
sijanced Jul 21, 2025
d833889
Update src/domain/media/subtitle-formats/subtitle-converter.ts
sjiamnocna Jul 23, 2025
14fae39
Update src/domain/media/subtitle-formats/subtitle-converter.ts
sjiamnocna Jul 23, 2025
f576293
Update src/domain/media/subtitle-formats/subtitle-converter.ts
sjiamnocna Jul 23, 2025
1692634
Edited comments, tests passing
sijanced Jul 24, 2025
d43da6b
Some PR comments
sijanced Jul 25, 2025
a63e892
Removed some comments, added tests
sijanced Jul 28, 2025
2dacfce
Fix piping, tests, remove unnecessary comments
sjiamnocna Aug 7, 2025
afbec2e
Resolving comments, fixed liter, added tests, will continue with othe…
sijanced Aug 18, 2025
3c8e3c9
Removed logs, solve linter errors
sijanced Aug 19, 2025
f8b7dfb
API endpoint and tests
sjiamnocna Aug 20, 2025
d3a3505
Update src/domain/media/subtitle-formats/subtitle-converter.ts
sjiamnocna Aug 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@
"test": "vitest run",
"test:watch": "vitest",
"test:ui": "vitest --ui",
"test:subtitles": "vitest run src/domain/media/subtitle-formats/",
"test:subtitles:watch": "vitest src/domain/media/subtitle-formats/",
Comment on lines +13 to +14

@coderabbitai coderabbitai Bot Aug 20, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

test(scripts): align subtitle test commands with pnpm and add focused unit/integration runners

Given the repo uses pnpm (packageManager is pnpm@10.7.0), it’s clearer if the runner script and docs call pnpm script aliases. Recommend adding explicit unit/integration scripts so run-tests.sh and README don’t hardcode test file names.

Apply this diff to extend scripts:

   "scripts": {
     "dev:server": "bun --inspect-wait --watch src/server.ts",
     "start:server": "bun src/server.ts",
     "test": "vitest run",
     "test:watch": "vitest",
     "test:ui": "vitest --ui",
     "test:subtitles": "vitest run src/domain/media/subtitle-formats/",
     "test:subtitles:watch": "vitest src/domain/media/subtitle-formats/",
+    "test:subtitles:integration": "vitest run src/domain/media/subtitle-formats/test-enhanced-endpoints.test.ts",
+    "test:subtitles:unit": "vitest run src/domain/media/subtitle-formats/subtitle-processor-enhanced.test.ts",
     "check": "biome check --write .",
     "typecheck": "tspc --noEmit",
     "build": "tspc"
   },

This keeps CI stable and lets the shell script and README call pnpm run test:subtitles:* instead of invoking npm test -- ... directly.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"test:subtitles": "vitest run src/domain/media/subtitle-formats/",
"test:subtitles:watch": "vitest src/domain/media/subtitle-formats/",
"scripts": {
"dev:server": "bun --inspect-wait --watch src/server.ts",
"start:server": "bun src/server.ts",
"test": "vitest run",
"test:watch": "vitest",
"test:ui": "vitest --ui",
"test:subtitles": "vitest run src/domain/media/subtitle-formats/",
"test:subtitles:watch": "vitest src/domain/media/subtitle-formats/",
"test:subtitles:integration": "vitest run src/domain/media/subtitle-formats/test-enhanced-endpoints.test.ts",
"test:subtitles:unit": "vitest run src/domain/media/subtitle-formats/subtitle-processor-enhanced.test.ts",
"check": "biome check --write .",
"typecheck": "tspc --noEmit",
"build": "tspc"
},
🤖 Prompt for AI Agents 
In package.json around lines 13-14, the current subtitle test scripts call
vitest directly and don't provide pnpm-friendly aliases or explicit
unit/integration runners; update the scripts section to (1) expose these scripts
as pnpm-invokable entries (so callers use `pnpm run test:subtitles:*`), and (2)
add explicit focused runners such as `test:subtitles:unit` and
`test:subtitles:integration` (and watch counterparts) that run vitest against
the appropriate unit or integration test globs/dirs; ensure names and semantics
match run-tests.sh and README so they no longer hardcode npm invocations or file
paths.

"check": "biome check --write .",
"typecheck": "tspc --noEmit",
"build": "tspc"
Expand Down
40 changes: 28 additions & 12 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading