Skip to content

fix: make prompt-template loading atomic and reload-safe - #734

Merged
MaryammAli merged 2 commits into
BlockDash-Studios:mainfrom
Bashman10:codex/fix-issue-652
Aug 27, 2026
Merged

fix: make prompt-template loading atomic and reload-safe#734
MaryammAli merged 2 commits into
BlockDash-Studios:mainfrom
Bashman10:codex/fix-issue-652

Conversation

@Bashman10

Copy link
Copy Markdown
Contributor

Summary

  • Make prompt-template reloads atomic so failed loads preserve the active valid configuration.
  • Reject prompt-template paths that escape the application directory.
  • Add regression coverage for malformed reloads, invalid template structures, and path traversal.

Verification

  • npx jest --config jest.config.ts src/ai/prompt-template.service.spec.ts --runInBand
  • git diff --check

Notes

  • The repository-wide lint and build checks currently fail on upstream main because of pre-existing, unrelated configuration and TypeScript errors.

Closes #652

@drips-wave

drips-wave Bot commented Aug 27, 2026

Copy link
Copy Markdown

@Bashman10 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@MaryammAli MaryammAli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryammAli MaryammAli left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaryammAli
MaryammAli merged commit 690a37e into BlockDash-Studios:main Aug 27, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BA-084 — Make prompt-template loading atomic and reload-safe

2 participants