fix: validate external prompt-template schema deeply (BA-083) - #737
Merged
MaryammAli merged 2 commits intoAug 28, 2026
Merged
Conversation
Enforce deep validation of externally supplied prompt templates before activation: schema version and per-template version must be semver, template names must match a safe identifier pattern, required text fields (description, systemPrompt) must be non-empty, version arrays must be non-empty with unique versions, and nested approval/rollback metadata is structurally validated.
|
@Tim4evar Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…#653 approval gating The 'keeps the last valid templates' spec loaded a template with no approval, but getActiveTemplate (added in BlockDash-Studios#653) requires approval.status === 'approved', so the template was never active and the test failed on main. Adding an approval makes it active under current behaviour and turns the CI (src/ai) green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
External prompt-template configs are now validated deeply before activation. Previously only top-level field types were checked; malformed templates and invalid versions could slip through.
Issue
Closes #651
Changes
schemaVersionand every templateversionmust be valid semver.^[a-zA-Z][a-zA-Z0-9_-]*$).descriptionandsystemPromptmust be non-empty (required text).approval/rollbackmetadata is structurally validated.Validation
npx jest --config jest.config.ts --runInBand src/ai→ 35 passed.keeps the last valid templates when a later reload is malformed) fails onmainalready (unrelated; tied to BA-085 — Add prompt-template approval and audit metadata #653 approval gating), so it is not introduced by this PR.Notes
@typescript-eslint/eslint-pluginmissing) is a pre-existing environment issue and does not affect CI.Known CI note
The
Learner journey & AI testsjob is currently red onmainfor an unrelated reason:src/integration/learner-journey.spec.tscallsnew JwtTutorGuard(jwt)butJwtTutorGuard's constructor now requiresauthSessionService(seesrc/auth/guards/jwt-tutor.guard.ts:27). This is a pre-existing break inmain, not introduced by this PR. Thesrc/aisuite (this PR's scope) passes.