fix: disable TypeORM synchronize in production and staging - #743
Merged
Conversation
|
@AzahasTech Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR hardens database startup behavior by ensuring TypeORM
synchronizeis never enabled in production-like environments. Schema synchronization can mutate production data unexpectedly, so production and staging now forcesynchronize: false, making migrations the only supported schema-change path. An automated configuration test prevents regressions and documents the expected behavior for future changes.Related Issue
Closes #BA-025
Changes
🔒 TypeORM Synchronization Hardening
[MODIFY]
src/config/env.schema.tsDB_SYNCHRONIZE=truewhenNODE_ENVisproductionorstaging.[MODIFY]
src/database/database.module.tssynchronize: falsefor production and staging.synchronizeopt-in only for local development and test environments.[ADD]
src/database/database.module.spec.tssynchronizeisfalsefor both production and staging.[MODIFY]
src/config/config.module.ts[MODIFY]
.env.exampleDB_SYNCHRONIZE=falseas the safe default.Verification Results
Closes #593