fix(cors): enforce explicit origin allow-list in production - #749
Open
Adjutant500 wants to merge 1 commit into
Open
fix(cors): enforce explicit origin allow-list in production#749Adjutant500 wants to merge 1 commit into
Adjutant500 wants to merge 1 commit into
Conversation
- Reject CORS_ORIGIN='*' at startup when NODE_ENV is production or staging - Disable credentials when wildcard origin is configured (wildcard + credentials:true is a security vulnerability) - Add Joi schema enforcement: wildcard forbidden in production/staging, CORS_ORIGIN is required with no default in those environments - Export ENV_VALIDATION_OPTIONS from env.schema.ts (was imported but never exported, causing a latent TS error) - Add cors.spec.ts with 34 tests covering schema validation, runtime allow-list behaviour, and the bootstrap guard Closes BlockDash-Studios#662
|
@Adjutant500 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-Here's a PR description you can use:
──────────────────────────────────────────────────────────────────────────────────────────────────────────────────
fix(cors): enforce explicit origin allow-list in production (#662)
Summary
Fixes a permissive CORS configuration that allowed CORS_ORIGIN=* in production and unconditionally set
credentials: true — a combination that lets any attacker-controlled site read authenticated API responses.
Changes
src/main.ts
misconfigured deployments fail loudly rather than silently
wildcard + credentials is both browser-blocked and a security vulnerability
src/config/env.schema.ts
causing a latent TypeScript error
.env.example
src/config/cors.spec.ts (new, 34 tests)
comma-separated lists accepted everywhere
with an explicit list
Required action for deployment
Set CORS_ORIGIN to a comma-separated list of allowed origins before deploying to production or staging:
CORS_ORIGIN=https://rustacademy.xyz,https://www.rustacademy.xyz
The server will refuse to start without this.
closes #577