Repository navigation
Add single governed execution workflow - #26
blocksifrdev wants to merge 1 commit into
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ff5c48fd35
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| --arg actor "${{ github.actor }}" \ | ||
| --arg pr "${{ github.event.pull_request.number }}" \ | ||
| --arg sha "${{ github.event.pull_request.head.sha }}" \ | ||
| --argjson paths "$(jq -s . changed.txt | jq -R .)" \ |
There was a problem hiding this comment.
The --argjson paths expression currently runs jq -s . changed.txt before raw-string conversion, but changed.txt contains plain path lines, not JSON; with any normal file name this jq command exits with a parse error and the Authorize execution step fails under set -euo pipefail. This prevents the governance flow from reaching the authority call for typical PRs.
Useful? React with 👍 / 👎.
| if [ "$DECISION" = "PERMIT" ]; then | ||
| echo "✅ Execution permitted" | ||
| exit 0 | ||
| fi |
There was a problem hiding this comment.
When the authority returns STEP_UP, the step-up job runs and can receive manual environment approval, but the final gate still only permits DECISION=PERMIT and denies everything else. That makes the step-up path non-functional: even after successful human approval, enforce will always fail for STEP_UP decisions.
Useful? React with 👍 / 👎.
1 participant
No description provided.