Make Canvas too text transparency work (BL-16133)#7832
Open
JohnThomson wants to merge 1 commit intomasterfrom
Open
Make Canvas too text transparency work (BL-16133)#7832JohnThomson wants to merge 1 commit intomasterfrom
JohnThomson wants to merge 1 commit intomasterfrom
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| import { IColorInfo } from "../../../react_components/color-picking/colorSwatch"; | ||
| import { getRgbaColorStringFromColorAndOpacity } from "../../../utils/colorUtils"; | ||
|
|
||
| export function getPersistedCanvasColor(colorInfo: IColorInfo): string { |
There was a problem hiding this comment.
🟡 Exported function getPersistedCanvasColor missing required comment per AGENTS.md
The repository's AGENTS.md mandates: "All public methods should have a comment. So should most private ones!" The new exported function getPersistedCanvasColor in canvasColorUtils.ts has no comment explaining its purpose or behavior.
Suggested change
| export function getPersistedCanvasColor(colorInfo: IColorInfo): string { | |
| // Returns a color string suitable for persistence. For opaque colors, returns the hex | |
| // color directly. For partially transparent colors, bakes the opacity into an rgba() string. | |
| export function getPersistedCanvasColor(colorInfo: IColorInfo): string { |
Was this helpful? React with 👍 or 👎 to provide feedback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is