Fix heap buffer overflow in NDCELL decompression path#785
Open
saddamr3e wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a heap buffer overflow in the NDCELL filter caused by insufficient validation of block geometry embedded in the attacker-controlled
b2ndmetalayer.Root Cause
ndcell_forward()andndcell_backward()computed:using 32-bit arithmetic. A crafted
blockshapecould cause the product to wrap around and match the supplied block length, allowing malformed metadata to bypass validation.Subsequent index calculations used the actual block dimensions, which could lead to out-of-bounds memory accesses during filter processing.
Fix
int64_t.typesizevalues.blockshapedimensions.Tests
Added a dedicated regression test covering: