Feature/app slam#233
Merged
Merged
Conversation
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
reviewed
Jun 25, 2026
stefanvogel
requested changes
Jul 2, 2026
| #define CONFIG_LOG_SEVERITY (Logging::LOG_LEVEL_INFO) | ||
| #endif /* CONFIG_LOG_SEVERITY */ | ||
|
|
||
| /** TCP server IP address if not defined by the build configuration. */ |
Collaborator
There was a problem hiding this comment.
You should keep the old comment, now that you introduced
#ifndef APPSLAM_TCP_SERVER_IP
correctly. Same below for APPSLAM_TCP_SERVER_PORT
| void loop(); | ||
|
|
||
| /** | ||
| * Handle vehicle data received from SerialMuxProt and forward to ROS2 server. |
Collaborator
There was a problem hiding this comment.
Doxygen @brief descriptions must use third-person singular present tense ("Connects", "Returns", "Handles"), not imperative ("Connect", "Return", "Handle").
Collaborator
There was a problem hiding this comment.
Applies to other places in this header of course as well.
Collaborator
Author
There was a problem hiding this comment.
Applied to all comments
stefanvogel
requested changes
Jul 2, 2026
| { | ||
| LOG_WARNING("Failed to serialize vehicle data."); | ||
| } | ||
|
|
| void loop(); | ||
|
|
||
| /** | ||
| * Handle vehicle data received from SerialMuxProt and forward to ROS2 server. |
Collaborator
There was a problem hiding this comment.
Applies to other places in this header of course as well.
Collaborator
|
There are still 2 unresolved comments before I can review again... |
stefanvogel
requested changes
Jul 6, 2026
stefanvogel
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.