Skip to content

BD-7149 Update documentation for upcoming 18.0.0 release.#129

Open
akrupczynskirezolve wants to merge 21 commits intomainfrom
dev/18.0.0
Open

BD-7149 Update documentation for upcoming 18.0.0 release.#129
akrupczynskirezolve wants to merge 21 commits intomainfrom
dev/18.0.0

Conversation

@akrupczynskirezolve
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

@denniskoluris denniskoluris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akrupczynskirezolve looking great, just a couple of comments.


```xml
<service
android:name=".java.MyFirebaseMessagingService"
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to show .java or the package string, like com.example.app?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can define this service class with full package name (com.example.app.java.MyFirebaseMessagingService) or skip the package name and leave just enough information for the compiler to be able to identify the class in your code (as above).

This example was taken straight from official Android docs: https://firebase.google.com/docs/cloud-messaging/android/receive-messages#edit-app-manifest


The `pushnotifications` module uses **Firebase Cloud Messaging (FCM)** to receive push notifications. If your app doesn't use Firebase yet, follow the [official Android documentation](https://firebase.google.com/docs/cloud-messaging/android/get-started) to set it up.

> On Android 13 (API 33) and above, you must declare `POST_NOTIFICATIONS` permission in your manifest **and** request it at runtime.
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be an overkill to show how to request permissions for remote notifications?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a risk, cause simple permission request is not enough - developer should always handle user rejection of this permission or displaying permission rationale. And we'd have to add guides for both classic android and jetpack compose, so it gets complicated rather quickly. I'd rather just redirect the developer to official documentation.

Comment thread docs/Point SDK/Android/Push Notifications.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants