BD-7149 Update documentation for upcoming 18.0.0 release.#129
BD-7149 Update documentation for upcoming 18.0.0 release.#129akrupczynskirezolve wants to merge 21 commits intomainfrom
Conversation
denniskoluris
left a comment
There was a problem hiding this comment.
@akrupczynskirezolve looking great, just a couple of comments.
|
|
||
| ```xml | ||
| <service | ||
| android:name=".java.MyFirebaseMessagingService" |
There was a problem hiding this comment.
Is this supposed to show .java or the package string, like com.example.app?
There was a problem hiding this comment.
You can define this service class with full package name (com.example.app.java.MyFirebaseMessagingService) or skip the package name and leave just enough information for the compiler to be able to identify the class in your code (as above).
This example was taken straight from official Android docs: https://firebase.google.com/docs/cloud-messaging/android/receive-messages#edit-app-manifest
|
|
||
| The `pushnotifications` module uses **Firebase Cloud Messaging (FCM)** to receive push notifications. If your app doesn't use Firebase yet, follow the [official Android documentation](https://firebase.google.com/docs/cloud-messaging/android/get-started) to set it up. | ||
|
|
||
| > On Android 13 (API 33) and above, you must declare `POST_NOTIFICATIONS` permission in your manifest **and** request it at runtime. |
There was a problem hiding this comment.
Would it be an overkill to show how to request permissions for remote notifications?
There was a problem hiding this comment.
It's a risk, cause simple permission request is not enough - developer should always handle user rejection of this permission or displaying permission rationale. And we'd have to add guides for both classic android and jetpack compose, so it gets complicated rather quickly. I'd rather just redirect the developer to official documentation.
…-ios BD-7148 iOS Push Notifications
No description provided.