Add PDF request history inspection - #1
Open
Bobcat wants to merge 3 commits into
Open
Conversation
Owner
Author
|
Review follow-up is in
Checks: 116 passed; both changed JavaScript modules pass the Node syntax check. Port 8002 was left under the user's control. |
Owner
Author
|
Round 2 follow-up is in R1 now exits inspection mode completely after a failed history load. It restores the original New request controls, clears stale lifecycle and timing output, and returns the selector to New request. This also covers failure after a previously loaded historical request. R2 now clears the source iframe immediately when the selected request's artifacts have expired. Checks: 116 passed; the PDF view parses as ESM. The user-managed process on port 8002 was not restarted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The selector contains only initial PDF translations returned by translation-services. A rerender appears only as the transient current request and never enters the durable history list. Returning to “New request” restores the controls that were active before inspection.
This consumes the additive history and
request_optionsartifact API from Bobcat/translation-services#20. If that endpoint is unavailable or configured with a limit of zero, the selector stays hidden.Checks
.venv/bin/python -m unittest discover -s tests— 116 passednode --input-type=module --check < static/src/workflows/pdf-translation/index.jsnode --input-type=module --check < static/src/api-client.jsgit diff --check