Drop "None" from model comparison grid, make cards equal height - #258
Merged
aperson30 merged 1 commit intoSep 23, 2026
Merged
Conversation
The grid was showing 4 columns including "None" (view-only, not a segmentation model to compare) and letting each card's height follow its own content, so the row looked uneven. Filters "None" out of the comparison cards (it's still a normal dropdown option), and switches the grid to its default stretch alignment with height: 100% on each card so all cards in a row match the tallest one.
3 tasks
aperson30
added a commit
that referenced
this pull request
Sep 23, 2026
Follow-up to #258. The comparison cards looked uneven for two reasons: a mismatched amount of content per model (Atlas-Net only had one real fact to draw on, so its card looked comparatively empty), and content that genuinely differs in length (description text wraps to a different number of lines per card) throwing every section below it out of alignment between cards. Fixes the content gap by pulling real, previously undocumented facts about Atlas-Net straight from its label-mapping code (services/auto_segmentor.py _ATLASNET_TO_VIEWER): it's built on the same nnU-Net v2 architecture as ePAI (Dataset001_ATLASNet, 3D fullres), maps the same 25 raw structure labels, and separately identifies the same 3 pancreatic tumor subtypes (PDAC, cyst, PNET) - none of that was previously surfaced anywhere in the UI. Fixes the alignment by switching each card from independent flex-column stacking to a 9-row CSS subgrid (icon, name, badge, desc, button, divider, stats, divider, bullets) sharing row tracks with its siblings via the parent grid's explicit grid-template-rows. Every section now lines up across all three cards regardless of how many lines its own content takes, instead of drifting or leaving dead space when one card's content is longer or shorter than the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
alignItems: "start", addedheight: "100%"on each card) instead of top-aligning to content height.Test plan
npx vitest run src/test/modelComparisonCards.test.tsx src/test/planGating.test.tsx- 16/16 passnpx vitest run(full suite) - 331/331 pass (one unrelated pre-existing flake reproduced and cleared on rerun, same test file, unrelated to this diff)npx tsc -b- clean