Skip to content

Stable organ chip size, lock page scroll in viewer, hover-identify default, red lesion - #268

Merged
aperson30 merged 1 commit into
BodyMaps:mainfrom
aperson30:fix/organ-chip-stable-size-scroll-lock
Oct 1, 2026
Merged

aperson30 merged 1 commit into
BodyMaps:mainfrom
aperson30:fix/organ-chip-stable-size-scroll-lock

Conversation

@aperson30

Copy link
Copy Markdown
Collaborator

Summary

  • Organ chips no longer resize on click. They toggled border-0 / border-2, so a click shrank the chip and shifted every row below it. The 2px border is now always present (.vp-organ-chip) and only its color changes. Applies to organ rows, the Pancreas/Colon/Kidneys group headers, Custom Classes, and the compare viewer.
  • Viewer no longer scrolls the whole window. Page scroll is locked while the viewer is mounted and panes get overscroll-behavior: contain, so a wheel tick a pane doesn't consume can't move the layout.
  • Hover-to-identify defaults to on. The View menu item still toggles it off. (The eye button now reads as active by default.)
  • Pancreatic lesion color [80, 0, 0] (dark maroon) to [240, 10, 10] (bright red).

Test plan

  • npx tsc -b clean
  • npx vitest run 345/345 pass
  • Localhost: click organs in the panel, confirm the chip keeps its size and only the outline color toggles
  • Localhost: scroll slices in each pane, including at the first/last slice and over the 3D pane, confirm the window stays put
  • Localhost: hover an organ with no tool selected and confirm the name tooltip appears

…r-identify on by default

Organ chips swapped border-0 <-> border-2 when toggled, so clicking an organ
shrank the chip and shifted everything below it. The 2px border is now always
present and only its color changes (shared .vp-organ-chip class, used by the
single viewer and the compare viewer).

Scrolling over the viewer could scroll the whole window when a wheel tick
wasn't consumed by a pane. The page is locked from scrolling while the viewer
is mounted and panes use overscroll-behavior: contain.

Hover-to-identify now defaults to on; the View menu still toggles it.

Pancreatic lesion color changes from dark maroon to bright red.
@aperson30
aperson30 merged commit ba3cf86 into BodyMaps:main Oct 1, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant