Repository navigation
Extract recent-uploads & search helpers + unit tests - #28
Merged
Merged
Conversation
- Move recent-uploads localStorage helpers from UploadPage into helpers/recentUploads.ts (no behavior change) - Move advanced-search query building and case-id parsing from Homepage into helpers/search.ts (no behavior change) - Add 14 unit tests for the two modules: dedup, 8-item cap, status updates, relative-time formatting, tumor/sex/age param mapping, and id parsing
Yusufa09
pushed a commit
to Yusufa09/BodyMaps-website
that referenced
this pull request
Jul 12, 2026
Extract recent-uploads & search helpers + unit tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extracts two pieces of bespoke logic into testable helper modules and adds unit tests for them. No behavior change — pure refactor + tests.
What moved
helpers/recentUploads.ts— the Upload page's localStorage "Recent Uploads" logic (load/add/update/format/color), previously inline inUploadPage.tsx.helpers/search.ts— the dashboard's advanced-search query building (buildSearchParams) and case-id parsing (itemToId), previously inline inHomepage.tsx.UploadPage.tsxandHomepage.tsxnow import from these modules; output is identical.Tests added (14 → 28 total)
sessionId, 8-item cap, status updates, relative-time formatting, status→color.itemToIdparsing + fallbacks;buildSearchParamstumor 1/0/omit mapping,sex[]/age_bin[]multi-append, optionalsort_by/per_page.Verified locally: 28 tests pass, type-check, and build all green.