Skip to content

Add bojagi - #3

Open
tchock wants to merge 3 commits into
mainfrom
add-bojagi
Open

Add bojagi#3
tchock wants to merge 3 commits into
mainfrom
add-bojagi

Conversation

@tchock

@tchock tchock commented May 28, 2021

Copy link
Copy Markdown
Member
                                                                                                                  <!-- 🎗add a PR label 🎗-->

Description

Detail

Checklist

  • 👌 design updates are Garden Designer approved (add the
    designer as a reviewer)
  • 🌐 demo is up-to-date (yarn start)
  • ⬅️ renders as expected with reversed (RTL) direction
  • 🤘 renders as expected with Bedrock CSS (?bedrock)
  • ♿ analyzed via axe and evaluated using VoiceOver
  • 💂‍♂️ includes new unit tests
  • 📝 tested in Chrome, Firefox, Safari, Edge, and IE11

@ghost

ghost commented May 28, 2021

Copy link
Copy Markdown

Bojagi review status

Review on Bojagi still pending!

Following stories have changed:

  • Components/Forms/Select
  • Components/Forms/Textarea
  • Components/Forms/MultiThumbRange
  • Components/Notifications/Notification
  • Components/Forms/Checkbox
  • Components/Dropdowns/Autocomplete
  • Components/Forms/Range
  • Components/Forms/Fieldset
  • Components/Typography/CodeBlock
  • Components/Forms/Input
  • Components/Dropdowns/Select
  • Components/Forms/Radio
  • Components/Forms/FauxInput
  • Components/Forms/MediaInput
  • Components/Dropdowns/Combobox
  • Components/Tooltips

See all stories: https://bojagi.io/app/github/Bojagi/zendesk-react-components/pull/3

@jzempel

jzempel commented Aug 16, 2021

Copy link
Copy Markdown

Is there a config option to set storybook layout for all components to padded in order to match the default?

@sime

sime commented Aug 17, 2021

Copy link
Copy Markdown
Member

@jzempel We'll see what we can do. @tchock is taking a look now.

@tchock

tchock commented Aug 17, 2021

Copy link
Copy Markdown
Member Author

@jzempel I added support for the global parameters in the preview.js file of Storybook. Until now it was only possible to set parameters in the stories file and for single stories. It's now supported in our next build of the CLI.

You need to install the next bojagi CLI build:

yarn add -D @bojagi/cli@next

And set layout to padded in the preview.js parameters:
https://github.com/Bojagi/zendesk-react-components/blob/main/.storybook/preview.js#L15

Deploying to Bojagi again should then have default storybook layouting on Bojagi :)

If you need anything else, just ping me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants