Fix: Add pagination handling to CloudFront distribution listing#1238
Open
ChadReitsma wants to merge 4 commits intoBoldGrid:masterfrom
Open
Fix: Add pagination handling to CloudFront distribution listing#1238ChadReitsma wants to merge 4 commits intoBoldGrid:masterfrom
ChadReitsma wants to merge 4 commits intoBoldGrid:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1238 +/- ##
===========================================
- Coverage 1.52% 1.52% -0.01%
- Complexity 19773 19782 +9
===========================================
Files 634 634
Lines 99758 99791 +33
===========================================
Hits 1521 1521
- Misses 98237 98270 +33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
Hey guys, is there something I can do to help speed up the merging process for this commit? It's a pretty simple fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CloudFront API will only return a maximum of 100 items per request.
If a user has more than 100 distributions they cannot test or purge the CDN from within WP Admin if the distribution item is not returned within the first 100 results.
These changes make the associated functions follow pagination markers to create an array of all distributions (not just the first 100).