Conversation
examples/levels/src/reverse.ts
Outdated
| ): WrapperPlaceOrderReverseParamsExternal[] { | ||
| const orders: WrapperPlaceOrderReverseParamsExternal[] = []; | ||
|
|
||
| // Place bid orders for cleared levels |
There was a problem hiding this comment.
Why do we care about cleared levels when this is just initial? is the idea that this is happening for tokens that already have been launched?
There was a problem hiding this comment.
If for whatever reason we need to switch markets this could be useful. Didn't see a good reason to remove it effectively
There was a problem hiding this comment.
Why is it useful for switching markets? Isnt the assumption with reverse orders being used that there is no maintenance and we just place all levels, not just up through cleared level.
Remove? This is new code.
There was a problem hiding this comment.
It could, in our narrow case no, but if a market was write locked or something and forced us to we would want to have this. Low probability edge case. Can remove don't care
examples/levels/src/reverse.ts
Outdated
| } | ||
|
|
||
| /** | ||
| * Gets the current level based on total tokens sold. |
There was a problem hiding this comment.
This doesnt work anymore with nonzero spreads on reverse orders
There was a problem hiding this comment.
If we need to get the current level because of the possibility of switching markets, the reason we have this, then wont it almost always be wrong?
And even if it was configured the same, wont spreads make it so that levels can get out of order and this will be off in the higher levels?
There was a problem hiding this comment.
it will be approximate and still serve the purpose of resetting on a new market
2 participants
No description provided.